TOPPView: opening 1D view from 2D view issues

OpenMS / OpenMS

The codebase of the OpenMS project

https://www.openms.de

Other

477 stars 314 forks source link

TOPPView: opening 1D view from 2D view issues #4346

Open timosachsenberg opened 4 years ago

timosachsenberg commented 4 years ago

There seem to be problems opening the 1D View on macOS Cataline. Confirmed on 2.4 release. @oliveralka can you quickly check if that has already been fixed in current develop?

Summary after screencast: Ok after a little screencast we found some general problems with this opening step not only related to macOS:

a) It opens two tabs for the fragment scan b) If IDs were annotated and you try to open an annotated spectrum from the 2D map, it will show as unannotated first. You have to click on the first spectrum in the list first. c) In some cases (opening an unannotated spectrum?) you have to click twice into the list to update the spectrum shown

oliveralka commented 4 years ago

"Survey Scan in 1D" works for me (10.15.1) in all (installer) versions on my system: OpenMS-2.4.0-release (9690d06) OpenMS-2.4.0-nightly-2019-01-26 OpenMS-2.4.0-nightly-2019-11-01 OpenMS-2.4.0-nightly-2019-11-16

or did you mean something else?

jpfeuffer commented 4 years ago

I think it was Right Click on a point and then Survey Scan in 1D, yes. @timosachsenberg should confirm

jpfeuffer commented 4 years ago

Confirmed by @KyowonJeong

timosachsenberg commented 4 years ago

maybe someone with a mac could look into that

jpfeuffer commented 4 years ago

@cbielow Since you are working on the GUI, maybe you encountered something here? Even if it does not fail on my Mac currently, it behaves strangely (e.g. displays the Survey scan instead).

jpfeuffer commented 4 years ago

How can you debug GUI applications on Mac? I always run into deadlocks with lldb.

timosachsenberg commented 4 years ago

hmm works fine on linux

cbielow commented 4 years ago

(e.g. displays the Survey scan instead).

But that's what you wanted, right?

hmm works fine on linux

Works fine on Windows as well

jpfeuffer commented 4 years ago

Ah oops, yes the initial issue was about survey scan. What if you try fragment scan?

cbielow commented 4 years ago

also works fine

jpfeuffer commented 4 years ago

Ok after a little screencast we found some general problems with this opening step not related to macOS:

a) It opens two tabs for the fragment scan
b) If IDs were annotated and you try to open an annotated spectrum from the 2D map, it will show as unannotated first. You have to click on the first spectrum in the list first.
c) In some cases (opening an unannotated spectrum?) you have to click twice into the list to update the spectrum shown

poshul commented 3 years ago

Is this still an issue? @cbielow

poshul commented 1 year ago

@cbielow is this fixed with your changes?

cbielow commented 1 year ago

I did not touch the behaviour of the views. So its likely to be in ghe same state as before.