OpenMS / OpenMS

The codebase of the OpenMS project
https://www.openms.de
Other
478 stars 317 forks source link

[DOC] Proofreading of the OpenMS documentation #6050

Open enetz opened 2 years ago

enetz commented 2 years ago

The OpenMS documentation is being written by many people in chunks that are usually written once together with a class and then rarely double-checked or proofread. Some typos, grammatical errors and suboptimal formulations remain in the documentation and should be fixed.

To start fixing this, build OpenMS from GitHub with the documentation. Read the built doc in OpenMS_build/doc/index.html . It should look similar to this: https://abibuilder.informatik.uni-tuebingen.de/archive/openms/Documentation/nightly/html/index.html (hint: here you will also find how to build OpenMS ;) )

Please look for:

Rebuild the documentation and double-check the updated documentation locally before submitting a pull request with your fixes.

timosachsenberg commented 2 years ago

Is there an easy way to find undocumented public methods? And Maybe an automated way to prioritize them by usage in tools and library?

greengypsy commented 2 years ago

Yes, there is a flag you need to turn on in the Doxyfile (WARN_IF_UNDOCUMENTED).

Screen Shot 2022-06-06 at 9 16 26 pm
timosachsenberg commented 2 years ago

Hmm these might be protected (hence the underscore). Having at least the public ones documented would already be great. Is there an option to fine tune warnings or would we need to do some post filtering (e.g. check warnings if they contain only protected or privat methods by checking for substring _(

greengypsy commented 2 years ago

I can't find any way to filter these to only public ones. A script might need to be created to filter the results are the doxyfile is run.