OpenMS / OpenMS

The codebase of the OpenMS project
https://www.openms.de
Other
477 stars 316 forks source link

TOPPView: fix glitches in 1D view and layer names #7549

Closed cbielow closed 2 months ago

cbielow commented 2 months ago

Description

This PR fixes the following issues:

1) when generating theoretical spectra in TOPPView with intensities < 100, the 1D View showed them with weird intensities, especially in "Percentage" mode. Also "flipped" mode was broken, e.g.

2) custom captions for layer names were empty, e.g. no peptide sequence for theoretical spectra was visible

before: image after: image

How can I get additional information on failed tests during CI

Click to expand If your PR is failing you can check out - The details of the action statuses at the end of the PR or the "Checks" tab. - http://cdash.openms.de/index.php?project=OpenMS and look for your PR. Use the "Show filters" capability on the top right to search for your PR number. If you click in the column that lists the failed tests you will get detailed error messages.

Advanced commands (admins / reviewer only)

Click to expand - `/reformat` (experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push. - setting the label "NoJenkins" will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests) - commenting with `rebuild jenkins` will retrigger Jenkins-based CI builds

:warning: Note: Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).