Comet executable version differs in quay container and repo

OpenMS / THIRDPARTY

External binary dependencies (e.g. search engine binaries) packaged in installers

2 stars 12 forks source link

Open jonasscheid opened 8 months ago

jonasscheid commented 8 months ago

Comet executable in recent container quay.io/biocontainers/openms-thirdparty:3.1.0--h9ee0642_3 differs from the one in this repo.

Container version: TOPPBase.cpp(1588): Comet Version extracted is: '# comet_version 2023.01 rev. 0

Version in this repo: TOPPBase.cpp(1630): Comet Version extracted is: '# comet_version 2023.01 rev. 2 (7c9150d)

Not sure how that could happen. @timosachsenberg Any ideas? They comet executable was exchanged a year ago --> commit before the 3.1.0 release.

The most recent comet version is needed to make sure the pin output and pepxml output of comet are the same. For more information see release

Let me know if I can assist with anything

timosachsenberg commented 8 months ago

comet-ms bioconda is at 2023010-2 so this seems recent hmm recipe links to: https://github.com/bioconda/bioconda-recipes/blob/master/recipes/openms-meta/meta.yaml#L146 maybe one needs to specify 2023010-2 there and rebuild the package? or just do a rebuild? @jpfeuffer do you know

jpfeuffer commented 8 months ago

Yes, update and rebuild is the safest.

jonasscheid commented 8 months ago

So first we need to update that one and then rebuild. I can update comet and see if a simple version bump helps.

jonasscheid commented 8 months ago

jonasscheid commented 8 months ago