search

OpenMS / THIRDPARTY

External binary dependencies (e.g. search engine binaries) packaged in installers
2 stars 12 forks source link

Feature/percolator-noxml #13

Closed mwalzer closed 7 years ago

mwalzer commented 7 years ago

Let's try percolator w/o xml links as we take care of xml ourselves. Also, smaller binaries. Maybe let's also keep the name of the binaries a bit more descriptive.

mwalzer commented 7 years ago

@jpfeuffer no way for me to check if the mac binaries would still be called the same as the dmg .. can you check?

jpfeuffer commented 7 years ago

Hey yes you need to mount the dmg, extract the pkg (installer is broken), then navigate to the binary. Not sure if you can do it on linux.

mwalzer commented 7 years ago

Jup, tried, but I'm unsure. The mount found me a file I suspect to contain the binary called Archive.pax ... Does it @jpfeuffer ?

jpfeuffer commented 7 years ago

yup

jpfeuffer commented 7 years ago

Ah and you should rename the files to a version independent name that matches the default in the adapter (in this case percolator[.exe])

jpfeuffer commented 7 years ago

What's the status here?

jpfeuffer commented 7 years ago

Please update and remove the linux binary. Was update in #15 already.

timosachsenberg commented 7 years ago

already included by lukas PR