search

OpenMS / THIRDPARTY

External binary dependencies (e.g. search engine binaries) packaged in installers
2 stars 12 forks source link

[ADD] Sirius3.5 (linux, osx, win) #14

Closed oliveralka closed 7 years ago

oliveralka commented 7 years ago

Executables and libraries of Sirius3.5 for the SiriusAdapter

jpfeuffer commented 7 years ago

Hmmm hmmm.. not sure what to do about this. It will be our first GUI app and it requires a lot of redundant Java libraries and startup scripts. We should discuss a bit before merging.

oliveralka commented 7 years ago

Updated Pull request. Only one Library for Sirius class files. Library files for glpk for each Os. Different executables for each Os.

jpfeuffer commented 7 years ago

Okay great! Only one thing: Can you check if we can get rid of some libraries if we do not use the GUI? Then I would be for a merge.

oliveralka commented 7 years ago

This seems to be the minimal possible build, right now.

jpfeuffer commented 7 years ago

Ok. If you give me your ok because of our discussion of the filenames, I will merge. Tell me when your thirdparty test passes.

oliveralka commented 7 years ago

test passed - should be fine!

jpfeuffer commented 7 years ago

Oops I think the automatic merge via svn checkout fails with that structure..

jpfeuffer commented 7 years ago

I will look for an alternative

jpfeuffer commented 7 years ago

svn export --force works. will update travis

oliveralka commented 7 years ago

Should I open a new pull request? What is the Problem?

jpfeuffer commented 7 years ago

No fine. Can stay closed here.