search

OpenMS / THIRDPARTY

External binary dependencies (e.g. search engine binaries) packaged in installers
2 stars 12 forks source link

Change Percolator executable 64bit to statically linked version #15

Closed lukaszimmermann closed 7 years ago

lukaszimmermann commented 7 years ago

This PR addressed issue 2800 of OpenMS.

The executable of percolator was built from commit 76c5ab1aba0bb7916c90283da1dd5c46032c08d9 without XML support. Further, the executable is now statically linked. The advantage is that it is compatible with more Linux distributions (I tested on Arch Linux, Ubuntu 16.04, Red Hat 4.8.5-4, Red Hat 4.8.5-11).

In particular, the executable now works on the ABi cluster.

The disadvantage is that the size of the executable is now inflated to 12M. Is this a problem?

hroest commented 7 years ago

The disadvantage is that the size of the executable is now inflated to 12M. Is this a problem?

not really, I prefer a more portable solution. Thanks!