Closed lukaszimmermann closed 5 years ago
cool. could we use the ones from https://github.com/percolator/percolator/releases ?
Done
Percolator Update for Windows 32bit and 64bit added.
Mac is still missing?
Yes. I cannot perform the update, as I currently do not have access to a Mac.
@lukaszimmermann @jpfeuffer I am trying to build percolator static on MacOS (for this PR) - but I ran into some issues.
ld: library not found for -lcrt0.o
I use the following build script: percolator_build_osx.sh.zip
I think you cannot link everything static on MacOS. You have to be selective. At least all system libs should be fine to be dynamically linked. https://stackoverflow.com/questions/39278390/static-linking-with-dylib-ld-library-not-found-for-lcrt0-o-collect2-error-ld
@jpfeuffer Could you shortly test if the MacOS one is working for you?
It seems that static linking is not necessary for MacOS (thanks @lukaszimmermann).
Yes, Mac works. Rest is tested?
./percolator:
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 400.9.4)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
That is perfect, every Mac will have that.
Updates the Percolator executable to 3.02nightly, which contains new experimental options, such as
--train-best-positive
.This is now just the executable for Linux 64. For Mac, I would need a machine to build the executable there. I will try later for Windows at home.
Addresses: https://github.com/OpenMS/OpenMS/issues/3628