search

OpenMS / THIRDPARTY

External binary dependencies (e.g. search engine binaries) packaged in installers
2 stars 12 forks source link

[UPDATE] SIRIUS4.0 -> SIRIUS4.0.1 #51

Closed oliveralka closed 6 years ago

oliveralka commented 6 years ago

https://github.com/boecker-lab/sirius_frontend/blob/release/CHANGELOG.md Java issue will be fixed in 4.0.1 #46

This update will break some of the SiriusAdapter tests - which have to be updated. It seems the scores are different and some of the calculated sumformulas.

SiriusAdapter preprocessing (.ms) is working as expected.

jpfeuffer commented 6 years ago

Looks good. Did you test it? Or how can I?

oliveralka commented 6 years ago

@jpfeuffer I tested it on macOS and Linux (sl7). It works fine, but some of the tests are failing. I am working on a PR with updated VersionNumber and "fixed" tests. Additional I will ask the guys from Jena what the differences are and why the changes are sometimes e.g. double the score.

I will let you know when I am ready and tested everything - there seems to be a problem with the CSIFingerID Webservice.