search

OpenMS / THIRDPARTY

External binary dependencies (e.g. search engine binaries) packaged in installers
2 stars 12 forks source link

Mavenized - LuXor Snapshot 2.1 #60

Closed oliveralka closed 4 years ago

oliveralka commented 4 years ago

LuciPhor2 / LuXor had some issues with higher java version > 9

Tested: openjdk 13 2019-09-17

https://github.com/dfermin/lucXor/issues/2 https://github.com/dfermin/lucXor/issues/4

https://github.com/dfermin/lucXor/tree/mavenize

timosachsenberg commented 4 years ago

does this work with our Adapter? If so I would merge

oliveralka commented 4 years ago

Was tested using our Adapter (OpenMS 2.4.0, 2.5.0dev - macOS) with installed openjdk 13 2019-09-17.

Would be happy if someone else can test as well, but should work - the earlier version was only functional to java 9.

timosachsenberg commented 4 years ago

ok let's merge. Do we have some test data?

oliveralka commented 4 years ago

@timosachsenberg I added a "TOPP_LuciphorAdapter_1" thirdparty test a while ago.