OpenMS / THIRDPARTY

External binary dependencies (e.g. search engine binaries) packaged in installers
2 stars 12 forks source link

[ADD] SpectraST executable from TPP and README #7

Closed lukaszimmermann closed 7 years ago

lukaszimmermann commented 7 years ago

README contains description of the compilation specifications.

hroest commented 7 years ago

@jpfeuffer @cbielow is there a policy about having executables only for a single platform (e.g. Linux) or is that ok (for now)?

cbielow commented 7 years ago

Full coverage would be desirable, but having one is better than none I guess.

hroest commented 7 years ago

I agree, my view is lets start with Linux but eventually add the SpectraST executables for the other OS as well - I guess we could use the pre-compiled ones from the TPP distrubution?

jpfeuffer commented 7 years ago

Having only one platform is fine for now. We can disable the availability of the node e.g. in KNIME (on these platforms). Or include the node and require that the user finds/builds an executable himself and places it with the others. But yes, let's start with Linux.

hroest commented 7 years ago

so lets merge?

lukaszimmermann commented 7 years ago

I can test the windows executable on the weekend at home where I have access to a machine running Windows. For OSX I need to check, maybe I can get a Macbook for testing and building.

jpfeuffer commented 7 years ago

Where did you put the sources and the Makefiles now?

lukaszimmermann commented 7 years ago

In a separate repository: https://github.com/lkszmn/SpectraST

timosachsenberg commented 7 years ago

what'S the status here?

lukaszimmermann commented 7 years ago

Linux binary should be fine. I am going to prepare the Windows executables. TPP is not officially supported for Mac OSX. Should we try to include it anyway or omit the executable for this platform?

timosachsenberg commented 7 years ago

I think it would be great to have SpectraST on mac

lukaszimmermann commented 7 years ago

Ok I am going to try to build the executable on Mac

lukaszimmermann commented 7 years ago

Added executables for MacOS 64bit and Win64.

jpfeuffer commented 7 years ago

Mac works for me +1 (10.12.whatever)

jpfeuffer commented 7 years ago

win binary works too. will merge.