search

OpenMS / THIRDPARTY

External binary dependencies (e.g. search engine binaries) packaged in installers
2 stars 12 forks source link

SIRIUS 4.8.2 #74

Closed oliveralka closed 3 years ago

oliveralka commented 3 years ago

Update to SIRIUS 4.8.2

jpfeuffer commented 3 years ago

An own Java runtime? Hmm.. how large is the Sirius package these days?

oliveralka commented 3 years ago

It is actually quite extensive around 580 MB (altogether), but the java runtime is a requirement - we sometimes had funky issues on the cluster/cloud due to differences in the runtime.

Another option would be to tell everyone to download it themselves, but then I am not sure how that would work with the KNIME integration and testing (CI).

oliveralka commented 3 years ago

@jpfeuffer Do you think it is nevertheless OK to merge?

Edit: This was discussed in a meeting. It is fine for now.