search

OpenMS / autowrap

Generates Python Extension modules from Cythons PXD files
Other
73 stars 22 forks source link

Implement all operators #129

Open jpfeuffer opened 2 years ago

jpfeuffer commented 2 years ago

at least - missing

timosachsenberg commented 2 years ago

see https://github.com/OpenMS/OpenMS/issues/5914

timosachsenberg commented 2 years ago

@jpfeuffer how difficult would this be? Could this be an entry level task for new devs?

jpfeuffer commented 2 years ago

Without further checking, it should be copying two lines and write a test.

timosachsenberg commented 2 years ago

Perfect let’s use that for GSoC?

jpfeuffer commented 2 years ago

If someone does it, yes. But I would not wait forever.

timosachsenberg commented 2 years ago

yeah basically as qualification task

timosachsenberg commented 2 years ago

probably needs to be added here: https://github.com/OpenMS/autowrap/blob/8645068034085f761f8e7ea1e65f79223fd49cf3/autowrap/CodeGenerator.py#L673-L700

satvik-tha-god commented 2 years ago

Starting work on this!

I will add the '-' operator as a start

Arraxx commented 2 years ago

@satvik-tha-god can add more operators like '-=' and '*=' your views @jpfeuffer

erik-whiting commented 2 years ago

Hey I made a PR for adding % and %= for this issue here. If the PR looks good to y'all, I think this issue can probably get closed out. lmk what y'all think!