Closed hroest closed 9 years ago
after trying out the newest version, I get the following issue
Error compiling Cython file:
------------------------------------------------------------
...
self.inst = shared_ptr[_DataFilters](new _DataFilters())
def __getitem__(self, index ):
assert isinstance(index, (int, long)), 'arg index wrong type'
cdef long _idx = in_0
^
------------------------------------------------------------
pyopenms/pyopenms.pyx:38650:29: undeclared name not builtin: in_0
created pyopenms.cpp
copied files needed for distribution to pyopenms/
could this have something to do with 458c55a9eb7c3ec03c40de4d69aaf317e9eba1fe maybe?
Fixed this with 502c039187d095acd1a1b1819aa5e472efc9f080
I see that there is a special
__getitem__
method calledcreate_special_getitem_method
but I think there is an a slight logical problem here. In our case in OpenMS it generates code such aswhich does not make a lot of sense here to compare a
<size_t>index < 0
. The code is generated by a file calledsrc/pyOpenMS/pxds/DataFilters.pxd
which looks like thisother classes that use
int
instead ofSize
do not have this issue.In conclusion, I dont think it is a big problem but might be worthwhile to consider in the future