Codestyle - Githubissues

OpenMS / autowrap

Generates Python Extension modules from Cythons PXD files

Other

75 stars 22 forks source link

Codestyle #138

Open jpfeuffer opened 2 years ago

jpfeuffer commented 2 years ago

Type hints
Auto lint (flake, black, prettier,..?)
Documentation
require py 3.6 and use f-strings for all the template code. Maybe even use a templating library if we introduce more recursion to make it readable.

erik-whiting commented 2 years ago

Hey @jpfeuffer can I take the "Auto lint" part of this issue ahead of GSoC officially starting? I'd use black and maybe even pre-commit if you think that'd be useful (Biopython uses pre-commit but that project is much larger).

jpfeuffer commented 2 years ago

Hi @erik-whiting Yes! That would be great. Black is fine. For precommits, it would be great if you could put a hook in the repo which is not automatically installed so developers can choose if they want that in their GitHub cycle. Do you know what I mean?

erik-whiting commented 2 years ago

Made a PR here. I would've requested you as reviewer but I didn't see that option. Let me know if you want me to change anything!