search

OpenMS / contrib

Automated CMake build scripts for the OpenMS contrib libraries
Other
0 stars 21 forks source link

[ADD] set zlib osx deployment target (cmake) #107

Closed oliveralka closed 3 years ago

oliveralka commented 3 years ago

@jpfeuffer Any idea why this is not working in the CI? Ubuntu 20.04?

jpfeuffer commented 3 years ago

If I understand the if logic correctly you are trying to build it twice on Linux? I think I have done that change to other libraries e.g. Xerces. I just declared an Args variable that is empty for Linux. Then you don't even need an if case for the whole command.

oliveralka commented 3 years ago

OK, that is much cleaner - thanks a lot.

oliveralka commented 3 years ago

I think the issue is connected to the cmake version - worked like a charm locally on macOS/linux with 3.15, but fails with 3.21.2.