search

OpenMS / contrib

Automated CMake build scripts for the OpenMS contrib libraries
Other
0 stars 21 forks source link

Do NOT use manylinux Dockerfile here! #116

Closed jpfeuffer closed 1 year ago

jpfeuffer commented 2 years ago

It uses the contrib version from the OpenMS submodule, which is of course not updated yet when you push here. https://github.com/OpenMS/dockerfiles/blob/master/pyOpenMS/manylinux/Dockerfile#L16

timosachsenberg commented 2 years ago

Can you add some more hints what the proper way would be here. I can take a look after my vacation

jpfeuffer commented 2 years ago

What do you mean? Use the contrib repo instead. That's it.

jpfeuffer commented 2 years ago

Or just fix https://github.com/OpenMS/dockerfiles/issues/12

jpfeuffer commented 2 years ago

There has to be a contrib container and a contrib-openms-tested container one is triggered for every push here. The other for every push to OpenMS.

jpfeuffer commented 2 years ago

Or even better, let every PR here be tested against OpenMS immediately. The whole logic should receive an update anyway. You probably need a temporary archive for contrib artifacts, for every PR here.

jpfeuffer commented 2 years ago

Dozens of possibilities.

jpfeuffer commented 1 year ago

@timosachsenberg It makes even less sense now after moving. https://github.com/OpenMS/contrib/blob/master/dockerfiles/pyopenms/manylinux/Dockerfile#L16

This is a blocker.

timosachsenberg commented 1 year ago

https://github.com/OpenMS/contrib/pull/128