OpenMS / contrib

Automated CMake build scripts for the OpenMS contrib libraries
Other
0 stars 21 forks source link

Start using -A instead of the now deprecated Generator suffix #94

Closed jpfeuffer closed 4 years ago

jpfeuffer commented 4 years ago

i.e. you need to do -G "Visual Studio 17 2019" -A "x64" instead of -G "Visual Studio 17 2019 Win64". Oh well..

cbielow commented 4 years ago

is this flag backwards compatible with older VS generators?

jpfeuffer commented 4 years ago

Yes, should have been used since CMake 3.1 already (roughly VS2005, which has even been deprecated by CMake now). See e.g. https://cmake.org/cmake/help/latest/generator/Visual%20Studio%209%202008.html

cbielow commented 4 years ago

ok. feel free to merge.