search

OpenMS / dockerfiles

This repository holds Dockerfiles for creating docker images for several OpenMS configurations based on different base images.
2 stars 8 forks source link

add labels to help organize images by project #6

Open mwalzer opened 6 years ago

mwalzer commented 6 years ago

because best practices and to be courteous to BioContainers project

jpfeuffer commented 6 years ago

Should we then also base all images on the biocontainers image? Or create a separate one?

hroest commented 6 years ago

i think that is a good idea for compatibility but we may also want to have a minimal image for people that want to have as little overhead as possible

mwalzer commented 6 years ago

The labels are best practice for any project, but they are loosely defined metadata to the image instructions. I think it will do us no harm adopting the more palpable definitions the bio containers team are proposing even if we don't base on bio containers image. But I agree with @hroest we should go for a minimal image for ourselves first

mwalzer commented 6 years ago

but in any case, with multistage docker builds, that should be fairly managable. I'm very happy with that new docker development (since v17.05) :smiley: update: Just talked to Yasset, seems that they are changing that in the specifications for biocontainers, so other bases can be used.