search

OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
46 stars 55 forks source link

IMPORTANT master+ipynb should be under the OpenMS repo #151

Closed jpfeuffer closed 3 years ago

jpfeuffer commented 3 years ago

@rahul799 please change as soon as possible

rahul799 commented 3 years ago

Ok. @jpfeuffer can you please create a branch and give me write access to it in the openms repo.

jpfeuffer commented 3 years ago

You should have access to create and push branches, no?

rahul799 commented 3 years ago

No, I just have the access to pyopenms-extra repo.

jpfeuffer commented 3 years ago

Yes that is what I mean

jpfeuffer commented 3 years ago

But the branch is on your fork. Or is it?

jpfeuffer commented 3 years ago

I was asking because my test workflow did not trigger on the last push. Maybe you can check this instead?

rahul799 commented 3 years ago

Can you please send me the link to that?

jpfeuffer commented 3 years ago

https://github.com/OpenMS/pyopenms-extra/blob/master/.github/workflows/test-notebooks.yml

rahul799 commented 3 years ago

Quite strange... As I can see some commits are pushed after you added the workflow, It must have got triggered.

rahul799 commented 3 years ago

@jpfeuffer please have a look #152

jpfeuffer commented 3 years ago

Also your notebook job does not work when you commit directly to master. Or does not work anymore. See my recent commits.

rahul799 commented 3 years ago

Some dependency issues as I am trying to download the latest version of pandoc. I tested it locally by using the docker container and it was working fine. Let me have a look

rahul799 commented 3 years ago

That issue is fixed. But the test workflow still didn't work for this commit.

rahul799 commented 3 years ago

Fixed... @jpfeuffer can we close this issue now?