OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
43 stars 53 forks source link

update map alignment visualization in example workflow #227

Closed axelwalter closed 2 years ago

axelwalter commented 2 years ago

Plotting consensus maps before and after alignment with matplotlib according to the map alignment tutorial.

jpfeuffer commented 2 years ago

What happened with plotly?

jpfeuffer commented 2 years ago

I think it would be a cool showcase. You just forgot to import px

axelwalter commented 2 years ago

I removed it because this would be the only place where plotly is used, since we do everything else with matplotlib. Do you think it is better to keep that?

jpfeuffer commented 2 years ago

Hmm ok. We could also have a separate section on interactive plots and show an example with plotly.

jpfeuffer commented 2 years ago

No strong opinion. I see your point.

jpfeuffer commented 2 years ago

Did you show drawn compounds in the hover boxes?

axelwalter commented 2 years ago

Yes, the reason why I chose plotly in the first place is interactivity in the browser and notebooks. Maybe that is possible with something like mpld3 (https://mpld3.github.io/index.html). I like the idea with interactive plots so we should keep plotly in mind.

jpfeuffer commented 2 years ago

I mean plotly should definitely work in jupyter. With an extension, you can even interactively change the layout.

axelwalter commented 2 years ago

The compound names were passed in the hover_name argument to the scatter plot.

jpfeuffer commented 2 years ago

SMILES or formula?

axelwalter commented 2 years ago

Only the names. In the result df all possible compound names are attached to a feature, this list was shown on hover.

timosachsenberg commented 2 years ago

is this one working and done?

axelwalter commented 2 years ago

yes it's working