OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
43 stars 53 forks source link

add example how protein ids are linked to peptide ids based on the getIdentifier() function #235

Closed timosachsenberg closed 2 years ago

rahul799 commented 2 years ago

When I am printing

print(peptide_id.getIdentifier())
print(protein_id.getIdentifier())

am getting same output IdentificationRun1 in both the cases. Is this the link you are talking about?

timosachsenberg commented 2 years ago

Hi Rahul.

Exactly. But we need to document somewhere more prominent that this is needed to link peptides to proteins. Otherwise, if this link is not establised some algorithms fail.

rahul799 commented 2 years ago

Should I add it somewhere here https://pyopenms.readthedocs.io/en/latest/datastructures_id.html ? Maybe as a note?

timosachsenberg commented 2 years ago

that would be great. maybe in the very beginning before https://pyopenms.readthedocs.io/en/latest/datastructures_id.html#proteinidentification

rahul799 commented 2 years ago

Ok. I will raise a PR soon.