OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
42 stars 52 forks source link

Link fixin #252

Closed poshul closed 5 months ago

poshul commented 2 years ago

Fixed a bunch of stale links, added files for future nase tutorial

poshul commented 2 years ago

Should I be worried about the failing build_test?

jpfeuffer commented 2 years ago

It seems we did not have a working pyopenms build in 30? days, so there is not artifact anymore.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

timosachsenberg commented 2 years ago

there are autofixes available: https://github.com/OpenMS/pyopenms-extra/pull/252/checks?check_run_id=4879571790 does anyone know how trustworthy those are?

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

timosachsenberg commented 2 years ago

If the links work like this I think we can move forward here

poshul commented 2 years ago

Lint fails with ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/usr/local/lib/python3.7/site-packages/markupsafe/__init__.py)

jpfeuffer commented 2 years ago

This is an error in the action. See their GitHub repo. Should be a comment from me as well. There is a workaround using a fork from someone. But maybe the action was updated by now. Please check.

jpfeuffer commented 2 years ago

@timosachsenberg when fixing the API docs I saw quite some warnings like XYZ.rst never referenced anywhere. Including hyper score. Can you check this? Just build yourself locally and you will see.

Indeed I cannot find hyperscore except in the search.

jpfeuffer commented 2 years ago

Unfortunately we have a lot of warning now from the API docs. We should check if we can filter them somehow. Or do CI without building the API docs, which also takes a few minutes.

timosachsenberg commented 2 years ago

Why are these not referenced? What is missing?

timosachsenberg commented 6 months ago

can you revive this so we can move it over the finish line?

timosachsenberg commented 5 months ago

cool! thanks