OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
42 stars 52 forks source link

Detect common binder errors automatically #276

Closed timosachsenberg closed 1 year ago

timosachsenberg commented 2 years ago

Check for common errors:

  1. if we can detect automatically if the binder page breaks.
  2. if we can trigger regular rebuilds of the notebooks to detect errors in the bindings
jpfeuffer commented 2 years ago

We do that. For every push every file. For every PR only changed files.

timosachsenberg commented 2 years ago

just to make sure 1. and 2.?

jpfeuffer commented 2 years ago

In theory we should cover the binder functionality in the pyopenms tests. If binder breaks due to outside changes in Openms, then the pyopenms tests were not good enough.

jpfeuffer commented 2 years ago

You can try to trigger them from e.g. an Openms action but it will be hard to catch. No one will look in this repo here.

timosachsenberg commented 2 years ago

hmm I think we need to find a way to monitor the outcome of these actions. CDash seems to be a bit restricted in this regards. Maybe we should look for (additional) dashboard that just shows a traffic light and links back to the action log.

jpfeuffer commented 2 years ago

Yes but I am not sure if this tracks cross-repo

timosachsenberg commented 2 years ago

maybe something REST based that can be triggered with curl or similar to report the outcome

jpfeuffer commented 2 years ago

I think the correct way would be to have specific openms versions to be used. As part of the specification. So when this gets updated here, it will be tested again.

jpfeuffer commented 2 years ago

And to release Openms more often.