OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
45 stars 55 forks source link

Expand theoretical spectrum generation tutorial #291

Closed timosachsenberg closed 1 year ago

timosachsenberg commented 2 years ago
timosachsenberg commented 1 year ago

this issue is based on requests from users...

JeeH-K commented 1 year ago

Is it going to be included on readthedocs? @timosachsenberg

timosachsenberg commented 1 year ago

Hi. Yeah it would be great to look for the appropriate section in the readthedocs documentation (I think we already cover spectrum generation) and expand that a bit.

JeeH-K commented 1 year ago

https://openms.readthedocs.io/en/latest/openms-applications-and-tools/visualize-with-openms/views-in-toppview.html#d-view Here's the only place that talks about the theoretical spectrum generation. I'll try to add an extra page for this.

timosachsenberg commented 1 year ago

ah no this is pyopenms

timosachsenberg commented 1 year ago

https://pyopenms.readthedocs.io/en/latest/search.html?q=TheoreticalSpectrumGenerator&check_keywords=yes&area=default

JeeH-K commented 1 year ago

I'll expand here https://pyopenms.readthedocs.io/en/latest/hyperscore.html?highlight=theoretical%20spectrum#generate-a-theoretical-spectrum

Or do you mean the TheoreticalSpectrumGenerator itself?

timosachsenberg commented 1 year ago

e.g. or here https://pyopenms.readthedocs.io/en/latest/theoreticalspectrumgenerator.html?highlight=TheoreticalSpectrumGenerator#y-ion-spectrum but please decide for yourself

JeeH-K commented 1 year ago

A little bit off-topic maybe, but curious: https://pyopenms.readthedocs.io/en/latest/theoreticalspectrumgenerator.html?highlight=TheoreticalSpectrumGenerator#y-ion-spectrum "plot_spectrum" is implemented in pyopenms? It doesn't work with me

JeeH-K commented 1 year ago

https://github.com/OpenMS/pyopenms-docs/issues/338 I guess it doesn't correspond to the released pyopenms

timosachsenberg commented 1 year ago

@matteopilz

JeeH-K commented 1 year ago

Maybe it's worth mentioning in the document since we have got an issue opened lately. https://github.com/OpenMS/pyopenms-docs/pull/341

jpfeuffer commented 1 year ago

I think instead it should go into the changelog and one should just use the documentation that is corresponding to the version that they are using. Unfortunately, this selection is not very visible -> #342 should be fixed first

JeeH-K commented 1 year ago

Cannot agree more. I'd prefer the doc to correspond to the released version, not the nightly/develop version.

JeeH-K commented 1 year ago

Trying to solve this issue before working on doc: https://github.com/OpenMS/OpenMS/issues/6701

jpfeuffer commented 1 year ago

What to display as default is a different issue which should be discussed separately. The linked issue is about the visibility of the version switch.

jpfeuffer commented 1 year ago

By default I mean where pyopenms.readthedocs.io redirects to.