OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
43 stars 50 forks source link

Build errors': nightly.link/OpenMS/OpenMS/workflows/pyopenms-wheels/develop returns 404 #292

Closed tapaswenipathak closed 1 year ago

tapaswenipathak commented 1 year ago

To reproduce:

make html in docs/ dir.

tapaswenipathak@Tapaswenis-MacBook-Pro docs % make html                       
Running Sphinx v4.5.0

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/sphinx/config.py", line 332, in eval_config_file
    exec(code, namespace)
  File "/Users/tapaswenipathak/opensource/OpenMS/pyopenms-docs/docs/source/conf.py", line 58, in <module>
    download_file("https://nightly.link/OpenMS/OpenMS/workflows/pyopenms-wheels/nightly/{0}-wheels.zip?status=completed".format(OS), "wheels.zip")
  File "/Users/tapaswenipathak/opensource/OpenMS/pyopenms-docs/docs/source/conf.py", line 42, in download_file
    with contextlib.closing(urllib.request.urlopen(url,timeout=timeout)) as fp:
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/urllib/request.py", line 214, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/urllib/request.py", line 523, in open
    response = meth(req, response)
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/urllib/request.py", line 632, in http_response
    response = self.parent.error(
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/urllib/request.py", line 561, in error
    return self._call_chain(*args)
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/urllib/request.py", line 494, in _call_chain
    result = func(*args)
  File "/usr/local/Cellar/python@3.9/3.9.12/Frameworks/Python.framework/Versions/3.9/lib/python3.9/urllib/request.py", line 641, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

make: *** [html] Error 2
tapaswenipathak@Tapaswenis-MacBook-Pro docs % 

I think URL: https://nightly.link/OpenMS/OpenMS/workflows/pyopenms-wheels/nightly/{0}-wheels.zip?status=completed is responding w/ a 404, as nightly.link is reporting a expired link:

Screenshot 2022-08-18 at 12 57 01 PM

It errors, maybe requires a rebuild or some update/sync? https://github.com/oprypin/nightly.link/commit/3eab57bdab6cb7fbfb94cbf87e98b3d8dd826a78

Screenshot 2022-08-18 at 12 58 49 PM
tapaswenipathak commented 1 year ago

Found:

pyopenms-wheels is not getting published.

https://github.com/OpenMS/OpenMS/actions/workflows/pyopenms-wheels.yml?page=3

Screenshot 2022-08-18 at 1 10 12 PM

expired w/ last published 4 months ago:

Screenshot 2022-08-18 at 1 10 51 PM
tapaswenipathak commented 1 year ago
Screenshot 2022-08-18 at 1 16 20 PM Screenshot 2022-08-18 at 1 16 30 PM
jpfeuffer commented 1 year ago

@poshul Would be cool if you could add nightly pypi support. That would solve it

poshul commented 1 year ago

@jpfeuffer I can update the links to go to our pypi site if thats what you mean. I was not aware that we had ever had the nightly.link functionality successfully enabled.

jpfeuffer commented 1 year ago

I mean instead of links and some weird get mechanism, just add pyopenms to the requirements.txt (if it can handle multiple source repos).

jpfeuffer commented 1 year ago

We currently remove pyopenms from the requirements to install it later with the wheel. See actions.yml We should use this: https://dock2learn.com/tech/how-to-specify-non-pypi-requirements-in-your-requirements-txt-file/

poshul commented 1 year ago

so it looks like we use nightly.link for the build-test as well. And that it 404's regularly there too see https://github.com/OpenMS/pyopenms-docs/actions/runs/3713524133/jobs/6296460023 where it failed twice and succeeded on the third rerun.

jpfeuffer commented 1 year ago

Will be fixed with #313