OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
45 stars 55 forks source link

code cleanup: Unnecessary not found URLs? #296

Closed tapaswenipathak closed 2 years ago

tapaswenipathak commented 2 years ago

I think this part of the code is not required:

      {%- elif display_bitbucket %}
        {%- if check_meta and 'bitbucket_url' in meta %}
          <!-- User defined Bitbucket URL -->
          <a href="{{ meta['bitbucket_url'] }}" class="fa fa-bitbucket"> {{ _('Edit on Bitbucket') }}</a>
        {%- else %}
          <a href="https://bitbucket.org/{{ bitbucket_user }}/{{ bitbucket_repo }}/src/{{ bitbucket_version}}{{ conf_py_path }}{{ pagename }}{{ page_source_suffix }}?mode={{ theme_vcs_pageview_mode or "view" }}" class="fa fa-bitbucket"> {{ _('Edit on Bitbucket') }}</a>
        {%- endif %}
      {%- elif display_gitlab %}
        {%- if check_meta and 'gitlab_url' in meta %}
          <!-- User defined GitLab URL -->
          <a href="{{ meta['gitlab_url'] }}" class="fa fa-gitlab"> {{ _('Edit on GitLab') }}</a>
        {%- else %}
          <a href="https://{{ gitlab_host|default("gitlab.com") }}/{{ gitlab_user }}/{{ gitlab_repo }}/{{ theme_vcs_pageview_mode or "blob" }}/{{ gitlab_version }}{{ conf_py_path }}{{ pagename }}{{ page_source_suffix }}" class="fa fa-gitlab"> {{ _('Edit on GitLab') }}</a>

these, a few lines here: https://github.com/OpenMS/pyopenms-docs/blob/master/docs/source/_templates/breadcrumbs.html#L14-L27

jpfeuffer commented 2 years ago

This is a standard template. If we ever copy it, I would like it to work with gitlab and bitbucket as well. Jinja will not expand if those variables are not given, so this will not hurt.