search

OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
43 stars 50 forks source link

Update py version of wheel to install. #317

Closed jpfeuffer closed 1 year ago

jpfeuffer commented 1 year ago

Probably ubuntu_latest is now 22.04 and comes with py 3.10

jpfeuffer commented 1 year ago

Another reason to fix #313 ASAP

jpfeuffer commented 1 year ago

Otherwise we should parse the python version and pass it to the glob pattern for the wheel

jpfeuffer commented 1 year ago

Or we set up a specific python as in CI.

jpfeuffer commented 1 year ago

@timosachsenberg I Was also tagging for some input on the way forward

timosachsenberg commented 1 year ago

"Otherwise we should parse the python version and pass it to the glob pattern for the wheel" yeah I think that works but might also a be a bit fragile

Wouldn't we like to set the python version dependent on the (e.g., highest python version) wheel that is available? e.g., choose the compatible python version

Not sure if this can be injected into:

    - uses: actions/setup-python@v4
      with:
        python-version: '3.10'
jpfeuffer commented 1 year ago

But there is not other way, you cannot let python find the correct wheel to install for you. You have to tell it. Unless you have a pypi repo