search

OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
45 stars 55 forks source link

test blacken #336

Closed jpfeuffer closed 1 year ago

matteopilz commented 1 year ago

I left some comments on the closed pr, it looks like it doesn't work.

jpfeuffer commented 1 year ago

It does work but always reports exit code 1. I think I am going to write my own script. Blacken is too bugged. See all my issues: https://github.com/adamchainz/blacken-docs/issues/

matteopilz commented 1 year ago

Before you do that, I would like to try it with flakeheaven again if possible. It seems the output is compatible with reviewdog.

matteopilz commented 1 year ago

I think we could tell flakeheaven to ignore a specific line e.g. :linenos: with :linenos: # noqa.

jpfeuffer commented 1 year ago

@matteopilz works now.