OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
43 stars 50 forks source link

Add furo theme to pyopenms.readthedocs.io #339

Closed tapaswenipathak closed 1 year ago

tapaswenipathak commented 1 year ago

Ref:

Fixes https://github.com/OpenMS/pyopenms-docs/issues/284.

tapaswenipathak commented 1 year ago

cc @tjeerdijk @jpfeuffer.

tapaswenipathak commented 1 year ago

Options:

Screenshot 2023-02-18 at 3 31 06 PM Screenshot 2023-02-18 at 3 27 02 PM
Screenshot 2023-02-18 at 3 27 09 PM Screenshot 2023-02-18 at 3 30 59 PM
Screenshot 2023-02-18 at 10 11 00 PM Screenshot 2023-02-18 at 10 12 45 PM Screenshot 2023-02-18 at 10 13 01 PM

Another one with 🚀:

Screenshot 2023-02-18 at 10 30 04 PM
Screenshot 2023-02-18 at 10 39 26 PM Screenshot 2023-02-18 at 10 39 36 PM
jpfeuffer commented 1 year ago

Unfortunately, the discussion in #339 was never finished. I don't think Furo is the best theme for us anymore. No good version selection, announcement banner for "launch in binder" is a bad hack.

The pydata theme is IMHO a much better fit. https://github.com/pydata/pydata-sphinx-theme

jpfeuffer commented 1 year ago

Ok, that looks better. I am a bit worried about the maintenance of the heavily modified internals of the underlying theme. I'll leave it up to others to decide if we use this theme with these addons or use a theme that actively supports what we need. @timosachsenberg @poshul @tjeerdijk @greengypsy