Changed files still not working correctly!

[jpfeuffer]

Describe the problem you encountered

Bugs were introduced in #325 because changed files never finds anything.

[matteopilz]

Can you be more specific with changed files never finds anything?

[jpfeuffer]

This action: https://github.com/OpenMS/pyopenms-docs/blob/master/.github/workflows/test-pr.yaml#L21

Check the last PRs and you will see that it never tests anything.

Also check the other workflows that use this action.

[timosachsenberg]

I don't see anything in Matteos PR that could crash it. @poshul any insight? Maybe this should be fixed before the next sprint as we otherwise can't close the outstanding PRs etc.?

[poshul]

I don't see anything in Matteos PR that could crash it. @poshul any insight? Maybe this should be fixed before the next sprint as we otherwise can't close the outstanding PRs etc.?

I'll take a look

[jpfeuffer]

Matteos PR introduced errors in the code. Not in the action. It introduced errors because the action was not working.

[poshul]

@jpfeuffer can you check https://github.com/OpenMS/pyopenms-docs/pull/350 the change there fixed the action in my demo cases.

[poshul]

fixed in #350.

[jpfeuffer]

Still not working! #357

[poshul]

Hmm, at least its a different error this time! I'll take a look

[poshul]

https://github.com/OpenMS/pyopenms-docs/actions/runs/4253340667/jobs/7398075580 ran fine https://github.com/OpenMS/pyopenms-docs/actions/runs/4253340641/jobs/7398075312 failed. Pretty sure this is because of https://github.com/tj-actions/changed-files/issues/809. I'm bumping to 35

[jpfeuffer]

OK seems to work. I hope it stays like that. good find.