search

OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
45 stars 54 forks source link

Fix changed-files #350

Closed poshul closed 1 year ago

poshul commented 1 year ago

Path spec should be part of files: not path:

jpfeuffer commented 1 year ago

Is this going to be recursive? I want to have the option to have subfolders under source. Maybe there are some currently already.

poshul commented 1 year ago

Is this going to be recursive? I want to have the option to have subfolders under source. Maybe there are some currently already.

We have couple of things in docs/source/_templates I'll make a branch and see what the best way to handle this is.

poshul commented 1 year ago

Yup.

On Mon, Feb 20, 2023 at 6:33 PM Julianus Pfeuffer @.***> wrote:

@.**** commented on this pull request.

In .github/workflows/test-pr.yaml https://github.com/OpenMS/pyopenms-docs/pull/350#discussion_r1112208307:

@@ -24,6 +24,7 @@ jobs: dir_names_max_depth: 0 files: | docs/source/*.rst

  • docs/source/*/.rst

this looks like it will still check the _templates, right?

— Reply to this email directly, view it on GitHub https://github.com/OpenMS/pyopenms-docs/pull/350#pullrequestreview-1306167956, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABD3C5GSTEUWXPTHW2RAMLWYOTHZANCNFSM6AAAAAAVBZUOX4 . You are receiving this because you authored the thread.Message ID: @.***>

jpfeuffer commented 1 year ago

Ah ok. I thought you were looking to exclude templates :D We actually don't need to check them.

Can you do the same for the other actions? For rst to ipynb conversion we actually NEED to exclude _templates since it would fail.

poshul commented 1 year ago

Ahh, I parsed your response wrong then. It looks like there is a possibility to exclude directories with !. I can add that as a line here as well.