OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
45 stars 54 forks source link

[FEATURE] First try with pydata theme #354

Closed jpfeuffer closed 1 year ago

jpfeuffer commented 1 year ago

image

jpfeuffer commented 1 year ago

Instead of rocket icon, we could have binder icon.

I envision having different docs on the main header:

When we fix the structure, we will have a left sidebar as usual. (Currently, everything goes automatically to the header)

timosachsenberg commented 1 year ago

any update here?

jpfeuffer commented 1 year ago

Hmm unfortunately pydata is really really slow with autosummary: https://github.com/pydata/pydata-sphinx-theme/issues/889

From 300 to 1000s build time on RTD. https://pyopenms.readthedocs.io/en/pydata-theme/index.html

jpfeuffer commented 1 year ago

@timosachsenberg Still waiting for feedback from people

timosachsenberg commented 1 year ago

Hmm unfortunately pydata is really really slow with autosummary: pydata/pydata-sphinx-theme#889

From 300 to 1000s build time on RTD. https://pyopenms.readthedocs.io/en/pydata-theme/index.html

hmm bummer... but do you consider this still ok-ish?

matteopilz commented 1 year ago

300 - 1000s are still fine I would say, Is that with building everything or only files changed?

jpfeuffer commented 1 year ago

Everything. We can also try some of the suggestions in the link from the issue: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/performance.html#build-performance-and-size

Let me know if you like it in general. I still want to do quite some smaller changes but the overall restructuring is finished.

timosachsenberg commented 1 year ago

I think it is great if it gets the side panel back.

jpfeuffer commented 1 year ago

It has. You need to click on a top bar link first, since the sidebar contents depend on this.

matteopilz commented 1 year ago

I also like it. If we exclude the _autosummary folder from the sidebar, the building time will probably be shorter.

timosachsenberg commented 1 year ago

ah ok and the top bar would not contain that many entries right? is there a working version up somewhere to get an idea how this would look like for the user?

jpfeuffer commented 1 year ago

Hmm unfortunately pydata is really really slow with autosummary: pydata/pydata-sphinx-theme#889

From 300 to 1000s build time on RTD. https://pyopenms.readthedocs.io/en/pydata-theme/index.html

Yep. See the second link in my comment.

matteopilz commented 1 year ago

Did you test it without autosummary?

jpfeuffer commented 1 year ago

You mean completely without autosummary? No, we need it for the API. I did not test the autosummary exclusion from the sidebar yet.

Of course, on a local computer it is usually relatively fast. And once the autosummary is generated it is even faster. But a full build on RTD is slow.

matteopilz commented 1 year ago

I meant excluding it from the sidebar.

timosachsenberg commented 1 year ago
jpfeuffer commented 1 year ago

a) was always the case. we can hide the TOC in the text. b) might also be related to caching? but I would not be surprised if it is a bit slower. It is not very noticeable for me though.

timosachsenberg commented 1 year ago

some images are not drawn https://pyopenms.readthedocs.io/en/pydata-theme/user_guide/ms_data.html

jpfeuffer commented 1 year ago

I could speed up generation by removing tocs from the API docs. Not ideally but also not too bad. Will merge

timosachsenberg commented 1 year ago

hmm I get a huge left border with adds now image

timosachsenberg commented 1 year ago

can the "User guide" be enabled by default and the sections expanded? so it looks a bit mroe like this: image

jpfeuffer commented 1 year ago

I think it has to have a landing page.

Yes toc can be expanded. See conf.py.

Ethical ads placement is default. See https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/readthedocs.html#add-ethical-advertisements-to-your-sidebar on how to change.

timosachsenberg commented 1 year ago