OpenMS / pyopenms-docs

pyOpenMS readthedocs documentation, additional utilities, addons, scripts, and examples.
https://pyopenms.readthedocs.io
Other
42 stars 50 forks source link

Name issue nightly pypi #362

Closed jpfeuffer closed 1 year ago

jpfeuffer commented 1 year ago

Currently the nightly pyopenms package has a different name! I think we tried to avoid the name clash on the public pypi back then -> I think we should name it back, now that we have an own pypi. Probably the logic in the pyopenms build action should be: if release, publish to public pypi AND local, if develop, publish only to local pypi with a .devDATE suffix (following PEP, as we do for conda).

Originally posted by @jpfeuffer in https://github.com/OpenMS/pyopenms-docs/issues/347#issuecomment-1436790546

poshul commented 1 year ago

What is a good way to test this?

jpfeuffer commented 1 year ago

How do you mean? AFAIR you need to do pip install pyopenms-nightly. As soon as you can do pip install pyopenms it will be fixed.

timosachsenberg commented 1 year ago

quick questions if someone already knows when setting up the action:

how to change the package name so it can be installed via pyopenms?

https://github.com/OpenMS/OpenMS/blob/develop/.github/workflows/pyopenms-wheels.yml#L479-L494

timosachsenberg commented 1 year ago

ah got it: https://github.com/OpenMS/OpenMS/blob/develop/src/pyOpenMS/setup.py#L44

https://github.com/OpenMS/OpenMS/pull/6749

jpfeuffer commented 1 year ago

Can you give this change a quick thought, too? Do you see a reason to include the nightly in the name instead of the version?

timosachsenberg commented 1 year ago

Hmm I don't see a reason why removing nightly could lead to trouble here. I have to admit that I don't know if anything depends on how this string needs to be formated. E.g. if some strange ambiguities arise (latest stable vs latest nightly).

jpfeuffer commented 1 year ago

Did you test? Did you check the pyopenms actions? Please link the according PR here, if so.

timosachsenberg commented 1 year ago

https://github.com/OpenMS/OpenMS/blob/develop/.github/workflows/pyopenms-wheels.yml

see: https://pypi.cs.uni-tuebingen.de/simple/pyopenms/

image

image

jpfeuffer commented 1 year ago

Thanks a lot!!

jpfeuffer commented 1 year ago

Not changed in environment.yml..

timosachsenberg commented 1 year ago

https://github.com/OpenMS/pyopenms-docs/pull/386

timosachsenberg commented 1 year ago

where else?

jpfeuffer commented 1 year ago

Should be all now.