Closed jpfeuffer closed 1 year ago
What is a good way to test this?
How do you mean?
AFAIR you need to do pip install pyopenms-nightly
. As soon as you can do pip install pyopenms
it will be fixed.
quick questions if someone already knows when setting up the action:
how to change the package name so it can be installed via pyopenms?
https://github.com/OpenMS/OpenMS/blob/develop/.github/workflows/pyopenms-wheels.yml#L479-L494
Can you give this change a quick thought, too? Do you see a reason to include the nightly in the name instead of the version?
Hmm I don't see a reason why removing nightly could lead to trouble here. I have to admit that I don't know if anything depends on how this string needs to be formated. E.g. if some strange ambiguities arise (latest stable vs latest nightly).
Did you test? Did you check the pyopenms actions? Please link the according PR here, if so.
Thanks a lot!!
Not changed in environment.yml..
where else?
Should be all now.
Currently the nightly pyopenms package has a different name! I think we tried to avoid the name clash on the public pypi back then -> I think we should name it back, now that we have an own pypi. Probably the logic in the pyopenms build action should be: if release, publish to public pypi AND local, if develop, publish only to local pypi with a .devDATE suffix (following PEP, as we do for conda).
Originally posted by @jpfeuffer in https://github.com/OpenMS/pyopenms-docs/issues/347#issuecomment-1436790546