window executable with embedabble python results huge file

Arslan-Siraj commented 5 months ago

how to setup to remove the no needed files?

t0mdavid-m commented 5 days ago

According to #96, it seems like there is nothing left to reduce here, correct?

(Once #68 is merged, where only relevant TOPP tools and all dll dependencies are copied)

cbielow commented 5 days ago

looking at our OpenMS Windows installer there are native Windows DLLs in there like shell32.dll. Reading up on it, we should not actually do that (its not allowed!) - see https://stackoverflow.com/questions/68345233/which-dlls-to-include-with-my-compiled-executable-distinguish-between-system-a

Bottom line: we need a manual list of dll's that we curate (luckily our dependencies do not change that often), but it's some effort initially and we'd need to test this on a fresh Windows VM which is as vanilla as possible to make sure we did not forget anything. On the bright side: the installer size will reduce considerably.

jpfeuffer commented 5 days ago

Interesting. Shell32 should indeed not be there. Here we tried to exclude some with patterns: https://github.com/OpenMS/OpenMS/blob/decb5c832cbf4e8fc85583fb6e44375150cdb3d4/cmake/package_general.cmake#L72

Feel free to try to adapt. Also depends a bit on the machine where it is built on. These days GHA runner.

OpenMS / streamlit-template

window executable with embedabble python results huge file #65