OpenMS / windows-installer

Former Windows Installer of OpenMS based on NSIS
1 stars 7 forks source link

Storage of Thirdparty binaries #2

Open jpfeuffer opened 8 years ago

jpfeuffer commented 8 years ago

We should think about unifying the storage place of the thirdparty binaries. For Windows, e.g. the nightlies access the SVN repo where all binaries (lnx,mac,win) are stored. On the other hand, in its current state, the installer in this repository "hard-codedly" takes the binaries from the to_install folder in this git repo. Potentially a source of errors. I do not even know, if the current versions of the binaries match.

jpfeuffer commented 8 years ago

Related to https://github.com/OpenMS/OpenMS/issues/1783.

jpfeuffer commented 8 years ago

And related to https://github.com/OpenMS/THIRDPARTY/issues/3. I will migrate as soon as the nightlies can handle it.

hroest commented 8 years ago

I have to say this usecase is actually one of the few cases where SVN makes much more sense than git. If I want a specific version of the binaries, I want to specify exactly that version and I do not want to have the whole history because I know that my version of OpenMS works exactly with those versions of the binaries.

timosachsenberg commented 8 years ago

I think this is supported by newer version of git. e.g. git archive --remote=ssh://host/pathto/repo.git HEAD README.md to get a single file. Also works with directories

timosachsenberg commented 8 years ago

@jpfeuffer I think we should remove the 3rd party binaries here and instead get them from the THIRDPARTY git repository

timosachsenberg commented 8 years ago

close?