search

OpenMW / openmw-deps-build

Apache License 2.0
0 stars 2 forks source link

Something didn't work properly #4

Closed AnyOldName3 closed 4 months ago

AnyOldName3 commented 4 months ago

@elsid looks like there are still some issues to iron out. https://github.com/OpenMW/openmw-deps-build/actions/runs/9293806579/job/25577757044

elsid commented 4 months ago

vcpkg warnings can be ignored, it works anyway. I've tested this in my fork:

https://github.com/elsid/openmw-deps-build/actions/runs/9246687679

results:

What happened with SSH I have no idea, the job output is:

Error loading key "(stdin)": error in libcrypto

Which probably means something is wrong with SSH key or its support. I've generated ssh-ed25519 for this. No evidence GPG didn't work so far.

AnyOldName3 commented 4 months ago

vcpkg warnings can be ignored, it works anyway. I've tested this in my fork

I'm aware, but it's still not a good idea to have warnings as a normal part of operation, especially when the fix is simple.

No evidence GPG didn't work so far.

The steps were skipped as if it was blank, which it isn't, but then that could well have just been because the job had already failed.

AnyOldName3 commented 4 months ago

I had what could be described as an idea. I'll kick off the build again.

AnyOldName3 commented 4 months ago

I'm now confident in saying it was an idea, and would even go as far as to say it was a good one, and so good that it should be applied to the GPG keys, too, as they died instead this time.

It seems that 1password swaps all whitespace in secrets for plain spaces, and both the SSH key import and GPG key import are sensitive to that.

AnyOldName3 commented 4 months ago

Bam! https://gitlab.com/OpenMW/openmw-deps/-/commit/9998ffbb93da45e5497bb71f935549516cf8b85f#7f8b755964d3775a4fcd0a31513c7922fab40892