OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
866 stars 435 forks source link

Unset additional product data if value is NULL || false || ' ' #1300

Open kkrieger85 opened 3 years ago

kkrieger85 commented 3 years ago

Unset attribute if not set instead of settings the attributes value to "no".

If "no" should be shown, then attribute should be used with yes/no instead of letting the attributes value empty. This leads to displaying empty product attributes in attribute tab on product detail page

Ref: https://github.com/OpenMage/magento-lts/blob/5dee1c0988e5ebd7fb458d6b72163c69a545c53f/app/code/core/Mage/Catalog/Block/Product/View/Attributes.php#L69

ADDISON74 commented 2 years ago

PR?