OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
869 stars 436 forks source link

Investigate Import/Export Orphan Row Bug from Magento 1.x #2010

Closed henryhayes closed 1 year ago

henryhayes commented 2 years ago

I have just tried uploading a CSV and appear to be having the symptoms of what was fixed by the Sandfox_ImportExportFix module, originally from the historic magento-hackathon project.

Does anyone have time to determine whether a) this has already been fixed and I'm experiencing something else; and b) if not, the suitability of including this into OpenMage?

tmotyl commented 2 years ago

@henryhayes can you install this module in openmage and see if it solves the problem? If yes then it would be good to incorporate the fix in openmage

fballiano commented 2 years ago

@henryhayes can you please provide some more info? maybe a CSV file that allows me to test this issue a little bit quicker? thanks

addison74 commented 2 years ago

Analyzing the original extension I found that it had a dedicated part for the import of products in Enterprise version and for the import of customers in CE version. You made a fork and corrected these issues by adapting it to CE version.

The main goal before starting the investigation is to clarify is related to the symptom you are referring to. How we can reproduce it? Your post does not bring any element to help us in this direction.

I looked in the exported CSV files for both Products and Buyers (OM-20.14) and I did not find orphaned rows. How did you get these rows that you refer to when you define the whole situation?

addison74 commented 1 year ago

The author can re-open this issue providing more information, especially how we can reproduce this issue, a CSV file for testing. I am closing and marking it with "Don't forget this issue" label. I did not evaluate the source code if the fix provided in that repository is requested in OM.