OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
863 stars 438 forks source link

Rewrote `js/varien/menu.js` without prototypejs but no longer linked in the `base` theme #3946

Closed fballiano closed 2 months ago

fballiano commented 2 months ago

This PR targets next

This menu.js is an ancient way of doing "hover", it's not used by RWD and it's linked in base but obviously base doesn't even have a styling so it's kinda useless there.

My original idea was to remove this file altogether but I've thought not to do that at the moment.

I've rewritten (and tested) this file without prototypejs and without ie6 code.

I've then removed the "linking" of this file within the base theme because, in the future, this unneeded way of dealing with hover should be removed altogether