Added support for Laravel Ignition

[fballiano]

Laravel Ignition is a pretty famous module for a better handling of error pages: https://flareapp.io/docs/ignition/introducing-ignition/overview

I thought it could be interesting for developers to have built-in, but absolutely optional (it's a pretty big package) in openmage.

The logic is:

• if there's a PHP error or exception
• and is in DeveloperMode
• and the spatie-ignition composer module is installed
• then the error is passed to ignition for the display

If DeveloperMode is disabled or the spatie-ignition package is not installed, OM behaves as usual. It shouldn't introduce any performance degradation.

This is the error page for a PHP error (function doesn't exist):

This is the error page for a default PHP exception:

And this is a Mage::throwException:

How to test

1. composer require "spatie/ignition" (as of 24 april 2024 you also need composer require laravel/serializable-closure)
2. enable developer mode
3. modify one of your files in order to generate an error

[empiricompany]

For those who want to try it immediately on latest v20.6.0

composer require "spatie/ignition"

add to your composer.json

"extra": {
    "enable-patching": true,
    "magento-force": true,
    "magento-core-package-type": "magento-source",
    "magento-root-dir": ".",
    "patches": {
        "openmage/magento-lts": {
            "Added support for Laravel Ignition #3954": "https://github.com/OpenMage/magento-lts/pull/3954.patch"
        }
    }
}

composer update

[empiricompany]

if i want to change theme here: this attempt to make this post request

[fballiano]

yep I don't think this "save configuration" works at all

[empiricompany]

yep I don't think this "save configuration" works at all

I started a discussion on how to better implement the integration: https://github.com/OpenMage/magento-lts/discussions/3955

[freekmurze]

Hi there 👋 Ignition creator here! It's cool that you're considering using our error page in Magento.

I notice that this merge was already reverted. If I can help in any way with integration this in Magento let me know! All questions welcome.

[empiricompany]

Hi @freekmurze! Thank you for your awesome package! We've decided to integrate Ignition in OpenMage via an external package: https://github.com/empiricompany/openmage_ignition/

As developer of the package empiricompany/openmage_ignition, is it possible to obtain a developer license for Flare ? I am currently in the trial period, which expires in 10 days.

We've also opened a PR to list our module among the compatible platforms: https://github.com/spatie/ignition/pull/628

[fballiano]

Hi @freekmurze it's an honor to have you here, as @empiricompany was saying we created a much better solution to integrate Ignition in OpenMage in an external module , supporting Flare and OpenAI suggestions ;-)

[freekmurze]

@empiricompany I can give you a coupon so you can use Flare for free. Send a mail to support@flareapp.io if you'd like that coupon 👍

[freekmurze]

I think Magento 2 could also benefit from having Ignition as its error page. Unfortunately, I'm not that familiar with the Magento community where I should pitch that idea.

If you think the maintainers of Magento 2 might be interested, feel free to send them my way should they have questions.

[fballiano]

@freekmurze Magento2 already has this: https://github.com/swissup/module-ignition ;-)