OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
863 stars 438 forks source link

Fixed: Fixer.io endpoint for currency updates #3958

Closed jankovandeventer closed 2 months ago

jankovandeventer commented 2 months ago

I tested it, and it works, in our own project I used an overwrite to make sure we can keep collecting data.

Description (*)

Recently there were some changes, this is the new endpoint if anyone is also using it 💸 The platform had a few changes over the years, but I think recently an endpoint was deprecated, resulting in no more updating our currency information.

The format is the same, just the url is changed and apiKey was renamed to access_key in the params.

Related Pull Requests

I believe this solves: https://github.com/OpenMage/magento-lts/issues/3071

Fixed Issues (if relevant)

I believe this solves: https://github.com/OpenMage/magento-lts/issues/3071

Manual testing scenarios (*)

  1. set up a free account on fixer.io
  2. add 2 or more currencies
  3. go to System -> Manage Currencies -> Rates
  4. Press import
  5. Success

image

Questions or comments

First PR for Open Mage, keep it up!

fballiano commented 2 months ago

if I open https://api.apilayer.com/fixer/latest on the browser it seems to work, is it not working at all for you?

is there any official info about the change?

hirale commented 2 months ago

https://apilayer.com/marketplace/fixer-api

image

fballiano commented 2 months ago

@hirale what do you mean? that the currently used address is working fine?

pquerner commented 2 months ago

Reads to me that apilayer is just a wrapper around the fixer api. So no change should be required.

https://apilayer.com/marketplace/fixer-api

fballiano commented 2 months ago

@jankovandeventer why did you need it? did the flexer api not work for you?

hirale commented 2 months ago

@hirale what do you mean? that the currently used address is working fine?

the current one works fine.

fballiano commented 2 months ago

let's see if the author of the PR explains us

fballiano commented 2 months ago

For the time being I'll close this PR, @jankovandeventer feel free to reopen if you're ve the answers to the questions asked here :-)

jankovandeventer commented 2 months ago

Hi there, sorry for not responding sooner. When I use the credentials with the apilayer, I get an invalid authentication warning.

image image

But I realize my mistake, the fixer.io credentials do not work on the apilayer so I had to move the subscription over to their new platform and now it works.

image

Sorry to bother :-)