search

OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
863 stars 438 forks source link

Updated PHPStan to 1.11.2 #3988

Closed fballiano closed 1 month ago

fballiano commented 1 month ago

@Flyingmana @Sdfendor @kiatng could you take a look at this?

fballiano commented 1 month ago

I've retested this (mostly where the parent::construct() was removed, becuase the parent contructor is empty), just to be safe, can't see any problem.

I'll merge it.

F1Red5 commented 1 month ago

@fballiano we have a modified abstract class Mage_Catalog_Model_Product_Type_Abstract with some custom code in save() method. With the removal of parent::construct() it does not work anymore. Can you please revert it?

fballiano commented 1 month ago

@F1Red5 could you override also the child class? I've removed it because phpstan complained that it's useless

fballiano commented 1 month ago

@F1Red5 check https://github.com/OpenMage/magento-lts/pull/4021 and if it solves (I think it's correct to restore the previous behavior) please vote for it.