OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
863 stars 438 forks source link

Edit attributes broken? #3996

Closed F1Red5 closed 1 month ago

F1Red5 commented 1 month ago

Preconditions (*)

  1. OM latest version
  2. PHP 7.4
  3. Sample Data pack installed

Steps to reproduce (*)

  1. Go to admin panel, "Manage Attributes"
  2. Select "Size" attribute, go to Labels/Options

Expected result (*)

  1. normal attribute edit page

Actual result (*)

  1. every option has a black square to select a color
  2. same with "Color", "Shoe Size" attribute and others, but not for all

Screenshot 2024-05-15 at 01-55-27 size _ Manage Attributes _ Attributes _ Catalog _ OpenMage Admin

What it is is for? Why have a color picker on size attributes? Why everything is black? Even on "Color" Attribute.

fballiano commented 1 month ago

it's the new swatches enhanced, check the release notes https://github.com/OpenMage/magento-lts/releases/tag/v20.7.0 and the original PR

it's enabled for all swatches attributes and that square is black because it's the default for input type color

right @empiricompany?

empiricompany commented 1 month ago

Yes, and it seems from the screen that the CSS hasn't been properly updated.

fballiano commented 1 month ago

right, I didn't notice that cause I'm on a slow connection today, @F1Red5 probably just need a hard refresh of your browser's cache

fballiano commented 1 month ago

@F1Red5 it should look like this

Screenshot 2024-05-15 alle 10 49 37