Configurable: remove unused double foreach loop - Githubissues

OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.

https://www.openmage.org

Open Software License 3.0

865 stars 436 forks source link

Configurable: remove unused double foreach loop #4008

Open Hanmac opened 4 months ago

Hanmac commented 4 months ago

Description (*)

The double foreach does nothing of value inside the Block:

it just calls $this->_preparePrice which just does format the price value.
but then it does nothing with it. Even where it supposed to go inside $_prices variable hasn't been working for 16 years since Magento 1.1 when this file was created.
In theory, the variables aren't even used and could be removed too. But that might be more of a BC break.

Related Pull Requests

Fixed Issues (if relevant)

Fixes OpenMage/magento-lts#2246

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All automated tests passed successfully (all builds are green)
[x] Add yourself to contributors list

fballiano commented 4 months ago

after reading the code I did a few tests and couldn't see any problem