Closed fballiano closed 1 month ago
@fballiano thank you.
I got feedback from our developer. He tried a bit to get rid of this warning. He wrote the error is gone when he replaced @return Mage_Catalog_Model_Product_Type_Abstract
with @return $this
in Mage_Catalog_Model_Product_Type_Abstract
. Can you verify this?
@F1Red5 I didn't understand
In Mage_Catalog_Model_Product_Type_Abstract
/**
* Save type related data
*
* @param Mage_Catalog_Model_Product $product
* @return $this <- he changed that line
*/
public function save($product = null)
{
/* custom code */
return $this;
}
@F1Red5 they changed a comment and fixed a problem?
He sent me this link: https://phpstan.org/r/f830ef1d-d81a-46fb-8ae1-2a5902672020
I'll ask him for more information tomorrow.
tell them to test this PR because I can't understand these messages
Okay. Thank you.
I cant explain, but I have tested the linked code and changed @return A
to @return $this
and the error is gone.
it should be exactly what this PR does, please test this one so that, if it fixes the problem, we can merge it
:+1:
do you people need a .1 release for this?
check https://github.com/OpenMage/magento-lts/pull/3988#issuecomment-2137828337