OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
865 stars 436 forks source link

Switched to ROW_FORMAT DYNAMIC for better compatibility with MariaDB 10.3 / 10.11 #4027

Closed alexh-swdev closed 3 months ago

alexh-swdev commented 3 months ago

Description (*)

I increased the version of Mage/Catalog to run a database migration script to alter the tables catalog/product_relations and catalog_product_website to not use ROW_FORMAT=FIXED anymore.

I decided to instead use ROW_FORMAT=DYNAMIC because it seems to be the standard on MariaDB: https://mariadb.com/kb/en/innodb-dynamic-row-format/

For more, see the discussion https://github.com/OpenMage/magento-lts/discussions/3962

Fixed Issues (if relevant)

Database fails to get imported to MariaDB 10.3. and 10.11. if InnoDB tables have ROW_FORMAT=FIXED

Questions or comments

I did manual tests on MariaDB 10.3 and 10.11. The results are looking good to me. (Meaning: the migration ran throug with success, the shops are still working :) , no apparent error messages or strange behavior)

I guess this should also work on MySQL but I don't have any at hand for testing. So maybe, before approving it, somenone wants to do some testing here.

Contribution checklist (*)

fballiano commented 3 months ago

Is this also supposed to fix new install? cause if I'm not mistaken it seems to fix only already installed projects

alexh-swdev commented 3 months ago

I only had already installed shops in my mind. I'll check against a new shop in the next couple of days.

fballiano commented 3 months ago
fballiano commented 3 months ago

also tested a new installation with no problem

fballiano commented 3 months ago

since nobody pitched in, I'll merge.