Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
The _doShipmentRequest method has a mistake in parsing the JSON response from UPS. Each successful response has a ShipmentResponse object under the root object.
Related Pull Requests
N/A
Fixed Issues (if relevant)
Should I make an issue first for this kind of thing?
Manual testing scenarios (*)
Do anything that requires getting shipping labels from UPS
Questions or comments
The Magento2 code for UPS has this right. When I implemented the OpenMage version, my brain just skipped over the ShipmentResponse key- probably because it looks so similar to the next key, "ShipmentResults". Here's the Magento2 part for reference:
Description (*)
The _doShipmentRequest method has a mistake in parsing the JSON response from UPS. Each successful response has a ShipmentResponse object under the root object.
Related Pull Requests
N/A
Fixed Issues (if relevant)
Should I make an issue first for this kind of thing?
Manual testing scenarios (*)
Do anything that requires getting shipping labels from UPS
Questions or comments
The Magento2 code for UPS has this right. When I implemented the OpenMage version, my brain just skipped over the ShipmentResponse key- probably because it looks so similar to the next key, "ShipmentResults". Here's the Magento2 part for reference:
We've been running this in production after encountering errors with generating shipping labels.
Contribution checklist (*)