search

OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
866 stars 436 forks source link

Bump phpstan/phpstan from 1.11.5 to 1.11.7 #4090

Closed dependabot[bot] closed 2 months ago

dependabot[bot] commented 2 months ago

Bumps phpstan/phpstan from 1.11.5 to 1.11.7.

Release notes

Sourced from phpstan/phpstan's releases.

1.11.7

Improvements 🔧

Bugfixes 🐛

Function signature fixes 🤖

  • getimagesize, getimagesizefromstring: zero is a possible value for height and width (#3207), thanks @​mfruehauf!

Internals 🔍

1.11.6

Bleeding edge 🔪

  • Precise array shapes for preg_match() for $matches by-ref parameter (#2589), thanks @​staabm!
  • Improved the type of the $mode parameter for the count() (#3190), thanks @​kuma3!

If you want to see the shape of things to come and adopt bleeding edge features early, you can include this config file in your project's phpstan.neon:

includes:
    - vendor/phpstan/phpstan/conf/bleedingEdge.neon

... (truncated)

Commits
  • 52d2bbf PHPStan 1.11.7
  • 18cddd6 Updated PHPStan to commit 18cddd6e556e2fb9e4c9a29eae2d5d87f2b18d68
  • fd31156 Updated PHPStan to commit fd3115652b76278fa6ddf8ba40b41fc751642153
  • 2c08dfa Updated PHPStan to commit 2c08dfa8d0f975654d52fe279a950c54415076b5
  • 7c61b03 Updated PHPStan to commit 7c61b0349307972f0f6918f9fc2d256da0da8d3d
  • 834dd27 Update BACKERS.md
  • d931c89 Updated PHPStan to commit d931c8987563fbe5a05e411722a6f53da6f1b555
  • 5a63154 Updated PHPStan to commit 5a631544b12ebb2e500d1666e37c000a64e192a6
  • 979055f Updated PHPStan to commit 979055fceeaefec30c1eded52550012f0c1333b6
  • 662aa66 Update result-cache.md
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
SuSiSonnenschein111 commented 2 months ago

@fballiano a simple unit test would be nice here. Somehow it looks "wrong"/changing ... $hostName = $matches[1] ?? null; changed to $hostName = $matches[1];?

fballiano commented 2 months ago

$matches[1] seems to always exist

Screenshot 2024-07-15 alle 13 32 27
github-actions[bot] commented 2 months ago

Test Results

7 tests   7 :heavy_check_mark:  0s :stopwatch: 3 suites  0 :zzz: 1 files    0 :x:

Results for commit c3b18e4f.

:recycle: This comment has been updated with latest results.

fballiano commented 2 months ago

I've added a few tests, there's always room for improvement but the change only affect ipv6 addresses and they should be covered by the tests

fballiano commented 2 months ago

If nobody is against this I'll merge it tomorrow

ADDISON74 commented 2 months ago

@sreichel - When you have some time available please take a look over this PR. We should benefit of the latest PHPstan version.

sreichel commented 2 months ago

Dont know why Magento did it that way ... preg_match will not return null for any part ... ?!?

Tried some regex ...

dependabot[bot] commented 2 months ago

A newer version of phpstan/phpstan exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

sreichel commented 2 months ago

Note: https://onlinephp.io?s=s7EvyCjg5QJBfX2FzLyyxJzMFAU9PT2FjPzy1LLUIl4ulYz84hK_xNxUBVsFdSMDA0Mrg5QkCyvjZJMUKyDPFEgYGEAIw0SjNCtDILAyAgIrYyBQtwaZXVCUmh6fm1iSnKGhrh8XE62hEW2ga5momxZbbahjUqtpr2GFLqIJpGvRRTU1VCECVbHamvYxsVBtQI6mvYp-prqOAty1QCbYwtRiTaATyhKL4lNKcws0kAXR3UUdV5HqDgA%2C&v=8.0.30%2C7.4.33%2C8.3.8%2C8.2.12

This Magento code was "beep" ... there is no match[6] at all ... i had no better idea to fix it.