search

OpenMage / magento-lts

Official OpenMage LTS codebase | Migrate easily from Magento Community Edition in minutes! Download the source code for free or contribute to OpenMage LTS | Security vulnerability patches, bug fixes, performance improvements and more.
https://www.openmage.org
Open Software License 3.0
866 stars 436 forks source link

Zip-Release 20.10.0 incomplete or too many items? #4093

Closed alexh-swdev closed 2 months ago

alexh-swdev commented 2 months ago

Preconditions (*)

  1. Downlaod the 20.10.0 release zip
  2. deploy

Steps to reproduce (*)

  1. Call a product page

Expected result (*)

  1. No errors, warning, log entries

Actual result (*)

  1. log entry about missing page-cache files grafik

In our current live installation as well as in my clean "Upgarde repo", there was no Page-Cache module. In the magento-lts github, there is also no Page-Cache module But in the releas zip, there it is: grafik

Is this on purpose? If so, are there missing files?

There are also community plugins in the zip file (Cm/Cache and Cm/RedisSession) which are not on github. Are those also supposed to be there?

ADDISON74 commented 2 months ago

PageCache shouldn't be there, that module was removed from /app/code/core/Mage some time ago. The ZIP archive contains also the full vendor directory, like you ran the composer install command. @fballiano will provide you more information related to this version.

alexh-swdev commented 2 months ago

The vendor directory is fine. That's why the openmage-vX.Y.Z.zip exists, additionally to source archives. But something seemed to have gone wrong with the rest.

fballiano commented 2 months ago

sorry for the late answer, If I remember correctly those modules are still bundles in OM v19, but they are removed from OM v20

sreichel commented 2 months ago

PageCache should not be there in v20 at all, but thats not the problem ...

The template/layout filse are not copied to app/design/frontend ...

You can copy it from vendor/openmage/module-mage-pagecache.

There are also community plugins in the zip file (Cm/Cache and Cm/RedisSession) which are not on github. Are those also supposed to be there?

Yes. This should be there.

sreichel commented 2 months ago

Close it.

With the next release all files should be there.